refactor: move composition api guide to increase discoverability #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencodezen
requested review from
NataliaTepluhina,
skirtles-code,
phanan and
sdras
There was a problem hiding this comment.
A couple of observations, neither of which prevent this from being merged:
- There's a certain amount of overlap between the Composition API and Reactivity guides. To me it seems more natural to introduce reactivity prior to composition, though the way the guides are currently written it doesn't seem to rely on either order.
- The guide to Render Functions should arguably move the other way. If any core topic counts as an 'Advanced Guide' then surely it's that. However, that move would be a little trickier after this PR because the Composition API guide mentions returning a render function from
setup.
sdras
approved these changes
Dec 26, 2020
Hey @skirtles-code, this is something we discussed in the vue docs meeting we hold once every two weeks- would you like to attend? If so, please email me: sarah.drasner@gmail.com, we think it would be great to have you there. We discussed what you were saying, but were also solving for some discoverability issues. |
|
@sdras I'm having trouble sending you an email (problem at my end, boring story). If you're on Vue Land Discord I'm available there as skirtle. Or on the Vue forum. |
|
@skirtles-code thanks! I'll go find you there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Users had troubles finding the guide in advanced and expected it to be in Reusability and Composition.
Proposed Solution
Additional Information